Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale secondary panel proportionally in Call (#258) #356

Merged
merged 19 commits into from
Mar 9, 2023
Merged

Scale secondary panel proportionally in Call (#258) #356

merged 19 commits into from
Mar 9, 2023

Conversation

Hirakota
Copy link
Contributor

@Hirakota Hirakota commented Feb 27, 2023 •
edited by SleepySquash
Loading

Resolves #258

Synopsis

Secondary panel dosen't scale after main panel resize

Solution

Change width/height after main panel resize proportionally

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@Hirakota
Resize secondary panel when parent resize
da0dd97
@Hirakota
Resize secondary panel when parent resize
ca66d57 
- refactor code
- scale after in/out fullscreen
@Hirakota
Resize secondary panel when parent resize
677669e 
- clean code
- fix scale after in/out fullscreen
@Hirakota Hirakota added the feature New feature or request label Feb 27, 2023
@Hirakota Hirakota self-assigned this Feb 27, 2023
@Hirakota Hirakota added k::UI/UX UI (user interface) and UX (user experience) changes enhancement Improvement of existing features or bugfix and removed feature New feature or request labels Feb 27, 2023
@Hirakota Hirakota added this to the 0.1.0-alpha.9 milestone Feb 27, 2023
@Hirakota Hirakota added the k::refactor Refactor changes of existing code label Feb 27, 2023
@Hirakota
Merge branch 'main' into scale-secondary-panel-call
faf25d4 
# Conflicts:
#	lib/ui/page/call/component/desktop.dart
@Hirakota Hirakota changed the title Scale secondary panel call on main panel size changes (#280) Scale secondary panel call on main panel size changes (#258) Feb 27, 2023
@Hirakota Hirakota changed the title Scale secondary panel call on main panel size changes (#258) Scale secondary panel proportionally in 'Call' after parent resied (#258) Feb 27, 2023
@Hirakota
Copy link
Contributor Author

Hirakota commented Feb 27, 2023 •
edited by SleepySquash
Loading

FCM

Implement proportional secondary panel resizing in `Call` (#356, #258)

@Hirakota Hirakota marked this pull request as ready for review February 27, 2023 12:36
SleepySquash
SleepySquash requested changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hirakota, попробуйте починить аналайзера и форматтера, пожалуйста, на CI.

@Hirakota Hirakota marked this pull request as draft February 27, 2023 12:56
@Hirakota Hirakota marked this pull request as ready for review February 27, 2023 13:50
@Hirakota Hirakota linked an issue Feb 28, 2023 that may be closed by this pull request
Scale secondary panel proportionally in 'Call' #258
Closed
SleepySquash
SleepySquash requested changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hirakota, в остальном всё ок! Вопросы в основном по стилю.

lib/ui/page/call/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/call/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/call/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/call/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/call/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/call/controller.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft February 28, 2023 08:11
@Hirakota
Improve code readability
5ea9e5e 
- rename variables
- reorganize code
@Hirakota Hirakota marked this pull request as ready for review February 28, 2023 09:27
@Hirakota
Fix comment message
e296d9d 
Additionally:
- reorganize code
@SleepySquash SleepySquash removed their request for review March 1, 2023 11:03
merlettoth
merlettoth reviewed Mar 2, 2023
View reviewed changes
lib/ui/page/call/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/call/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/call/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/call/component/desktop.dart Outdated Show resolved Hide resolved
lib/ui/page/call/controller.dart Outdated Show resolved Hide resolved
@merlettoth merlettoth marked this pull request as draft March 2, 2023 07:47
@Hirakota Hirakota marked this pull request as ready for review March 2, 2023 10:44
@Hirakota Hirakota requested a review from merlettoth March 2, 2023 10:44
SleepySquash
SleepySquash requested changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hirakota, в остальном всё LGTM!

lib/ui/page/call/controller.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft March 6, 2023 10:21
@Hirakota Hirakota marked this pull request as ready for review March 7, 2023 11:42
@SleepySquash SleepySquash changed the title Scale secondary panel proportionally in 'Call' after parent resied (#258) Scale secondary panel proportionally in Call (#258) Mar 9, 2023
@SleepySquash SleepySquash enabled auto-merge (squash) March 9, 2023 11:42
@SleepySquash SleepySquash merged commit 391e82a into main Mar 9, 2023
@SleepySquash SleepySquash deleted the scale-secondary-panel-call branch March 9, 2023 11:59
github-actions bot added a commit that referenced this pull request Mar 9, 2023
@github-actions
Implement proportional secondary panel resizing in Call (#356, #258) …
66b8fad 
…391e82a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

@merlettoth merlettoth merlettoth approved these changes

Assignees

@Hirakota Hirakota

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
No open projects
Way to 0.1.0-alpha.9
Status: Done
Milestone
0.1.0-alpha.9
Development

Successfully merging this pull request may close these issues.

Scale secondary panel proportionally in 'Call'
3 participants
@Hirakota @SleepySquash @merlettoth