Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mobile bottom dock on minimizing (#50) #53

Merged
merged 6 commits into from
Aug 3, 2022
Merged

Fix mobile bottom dock on minimizing (#50) #53

merged 6 commits into from
Aug 3, 2022

Conversation

krida2000
Copy link
Contributor

@krida2000 krida2000 commented Aug 2, 2022 •
edited by tyranron
Loading

Resolves #50

Synopsis

При уменьшении мобильного дизайна звонка, панель с кнопками разъезжается.

Solution

Размер панели с кнопками будет ограничен размерами окошка звонка.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@krida2000 krida2000 changed the title Fix mobile bottom dock on minimizing Fix mobile bottom dock on minimizing (#50) Aug 2, 2022
@krida2000 krida2000 self-assigned this Aug 2, 2022
@krida2000 krida2000 added this to the 0.1.0-alpha.6 milestone Aug 2, 2022
@krida2000 krida2000 added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Aug 2, 2022
@krida2000
Copy link
Contributor Author

krida2000 commented Aug 2, 2022 •
edited by SleepySquash
Loading

FCM

Fix `CallView` not accounting `MinimizableView` size (#53, #50)

@krida2000 krida2000 marked this pull request as ready for review August 2, 2022 09:02
SleepySquash
SleepySquash approved these changes Aug 3, 2022
View reviewed changes
lib/ui/page/call/component/mobile.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash enabled auto-merge (squash) August 3, 2022 10:01
@SleepySquash SleepySquash enabled auto-merge (squash) August 3, 2022 10:01
@SleepySquash SleepySquash merged commit 1b5a3f9 into main Aug 3, 2022
@SleepySquash SleepySquash deleted the 50-fix-mobile-bottom-dock-on-minimizing branch August 3, 2022 10:04
github-actions bot added a commit that referenced this pull request Aug 3, 2022
@github-actions
Fix CallView not accounting MinimizableView size (#53, #50)
ed8ca30 
Co-authored-by: SleepySquash <NordNikita@icloud.com> 1b5a3f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@krida2000 krida2000

Labels
enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.6
Development

Successfully merging this pull request may close these issues.

Mobile bottom dock on minimizing do not change size
2 participants
@krida2000 @SleepySquash