Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MessageField to allow pinning/unpinning action (#559) #609

Merged
merged 26 commits into from
Oct 6, 2023
Merged

Refactor MessageField to allow pinning/unpinning action (#559) #609

merged 26 commits into from
Oct 6, 2023

Conversation

krida2000
Copy link
Contributor

@krida2000 krida2000 commented Sep 26, 2023 •
edited by SleepySquash
Loading

Resolves #559

Synopsis

Добавилась возможность прикреплять и откреплять действия от поля отправки.

Solution

Нужно перенести изменения из new-design-preview.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@krida2000 krida2000 added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes k::refactor Refactor changes of existing code labels Sep 26, 2023
@krida2000 krida2000 added this to the 0.1.0-alpha.10 milestone Sep 26, 2023
@krida2000 krida2000 self-assigned this Sep 26, 2023
@krida2000
Copy link
Contributor Author

krida2000 commented Sep 26, 2023 •
edited by SleepySquash
Loading

FCM

Implement pinning `ChatButton`s in `MessageFieldView` (#609, #559)

- add `ApplicationSettings.pinnedActions` for pinned `ChatButton`s
- impl `MessageFieldMore` overlay for `MessageFieldView` actions

Additionally: 
- fix inability to edit `ChatMessage`s in `Chat`-monolog
- fix typo in Contribution Guide

@krida2000 krida2000 marked this pull request as ready for review September 26, 2023 13:47
SleepySquash
SleepySquash requested changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krida2000, давайте порассуждаем, пожалуйста, как мы можем решить проблему кнопок здесь, т.к. решение с CallButtonами показало себя непрактичным.

assets/l10n/en-US.ftl Outdated Show resolved Hide resolved
lib/ui/page/home/page/chat/message_field/components/buttons.dart Outdated Show resolved Hide resolved
lib/ui/page/home/page/chat/message_field/components/more.dart Outdated Show resolved Hide resolved
lib/ui/page/home/page/chat/message_field/components/more.dart Outdated Show resolved Hide resolved
lib/ui/page/home/page/chat/message_field/view.dart Outdated Show resolved Hide resolved
lib/ui/page/home/page/chat/message_field/view.dart Outdated Show resolved Hide resolved
lib/ui/page/home/page/chat/message_field/view.dart Outdated Show resolved Hide resolved
lib/themes.dart Outdated Show resolved Hide resolved
krida2000
krida2000 commented Oct 2, 2023
View reviewed changes
lib/store/chat_rx.dart Outdated Show resolved Hide resolved
SleepySquash
SleepySquash reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krida2000, просто мысли наперёд.

lib/ui/page/home/page/chat/message_field/widget/buttons.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash self-requested a review October 5, 2023 11:26
@SleepySquash SleepySquash merged commit 300b44e into main Oct 6, 2023
21 checks passed
@SleepySquash SleepySquash deleted the 559-message-field-pin-unpin-actions branch October 6, 2023 15:58
github-actions bot added a commit that referenced this pull request Oct 6, 2023
@github-actions
Implement pinning ChatButtons in MessageFieldView (#609, #559)
484b3ec 
- add `ApplicationSettings.pinnedActions` for pinned `ChatButton`s
- impl `MessageFieldMore` overlay for `MessageFieldView` actions

Additionally:
- fix inability to edit `ChatMessage`s in `Chat`-monolog
- fix typo in Contribution Guide

Co-authored-by: SleepySquash <nordnikita@icloud.com> 300b44e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@krida2000 krida2000

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.10
Development

Successfully merging this pull request may close these issues.

Refactor MessageField to allow pinning/unpinning actions
2 participants
@krida2000 @SleepySquash