Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grab cursor when dragging Participants in Call (#810) #816

Merged
merged 13 commits into from
Jan 26, 2024
Merged

Grab cursor when dragging Participants in Call (#810) #816

merged 13 commits into from
Jan 26, 2024

Conversation

krida2000
Copy link
Contributor

@krida2000 krida2000 commented Jan 19, 2024 •
edited by SleepySquash
Loading

Resolves #810

Synopsis

Тот факт, что участников звонка можно перетягивать, неочевиден.

Solution

Будет рисоваться SystemMouseCursors.grab курсор над участниками звонка.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@krida2000 krida2000 added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Jan 19, 2024
@krida2000 krida2000 added this to the 0.1.0-alpha.12 milestone Jan 19, 2024
@krida2000 krida2000 self-assigned this Jan 19, 2024
@krida2000
Copy link
Contributor Author

krida2000 commented Jan 22, 2024 •
edited by SleepySquash
Loading

FCM

Show `SystemMouseCursors.grab` cursor over `Participant`s in `Call` (#816, #810)

- impl `CustomMouseCursors` for `flutter_custom_cursor` on Windows

@krida2000 krida2000 marked this pull request as ready for review January 23, 2024 16:03
SleepySquash
SleepySquash requested changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krida2000, подумайте, пожалуйста, куда можно перенести инициализацию курсоров.

lib/main.dart Outdated Show resolved Hide resolved
lib/ui/page/call/component/desktop.dart Outdated Show resolved Hide resolved
lib/ui/page/call/component/desktop.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash merged commit 64e6d5f into main Jan 26, 2024
22 checks passed
@SleepySquash SleepySquash deleted the 810-grab-cursor-over-participants branch January 26, 2024 08:34
github-actions bot added a commit that referenced this pull request Jan 26, 2024
@github-actions
Show SystemMouseCursors.grab cursor over Participants in Call (#…
140bf74 
…816, #810)

- impl `CustomMouseCursors` for `flutter_custom_cursor` on Windows 64e6d5f
@SleepySquash SleepySquash mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@krida2000 krida2000

Labels
enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.12
Development

Successfully merging this pull request may close these issues.

Use SystemMouseCursors.grab cursor when dragging Participants in Call
2 participants
@krida2000 @SleepySquash