Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secondary panel modes switches to Call (#811) #837

Merged
merged 23 commits into from
Feb 8, 2024
Merged

Add secondary panel modes switches to Call (#811) #837

merged 23 commits into from
Feb 8, 2024

Conversation

kvbykov
Copy link
Contributor

@kvbykov kvbykov commented Feb 2, 2024 •
edited by SleepySquash
Loading

Resolves #811

Synopsis

Дизайн звонка на десктопе был изменен.

Solution

Изменения будут перенесены с new-desing-preview

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@kvbykov kvbykov marked this pull request as draft February 2, 2024 18:22
@kvbykov kvbykov self-assigned this Feb 2, 2024
@kvbykov kvbykov added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Feb 2, 2024
@kvbykov kvbykov added this to the 0.1.0-alpha.12 milestone Feb 2, 2024
@kvbykov kvbykov marked this pull request as ready for review February 5, 2024 17:32
@kvbykov
Copy link
Contributor Author

kvbykov commented Feb 5, 2024 •
edited by SleepySquash
Loading

FCM

Add `layoutAsPrimary` and `layoutAsSecondary` modes to desktop `Call` (#837, #811)

- refactor `CallTitle` to contain `AnimatedButton`s with layout modes
- refactor header of `PopupCall` to contain layout mode buttons

SleepySquash
SleepySquash approved these changes Feb 8, 2024
View reviewed changes
lib/ui/page/call/widget/title_bar.dart Outdated Show resolved Hide resolved
lib/ui/page/call/widget/title_bar.dart Show resolved Hide resolved
@SleepySquash SleepySquash added the k::refactor Refactor changes of existing code label Feb 8, 2024
@SleepySquash SleepySquash merged commit f1bdc04 into main Feb 8, 2024
22 checks passed
@SleepySquash SleepySquash deleted the 811-add-call-secondary-panel-modes branch February 8, 2024 09:44
github-actions bot added a commit that referenced this pull request Feb 8, 2024
@github-actions
Add layoutAsPrimary and layoutAsSecondary modes to desktop Call (…
d54a580 
…#837, #811)

- refactor `CallTitle` to contain `AnimatedButton`s with layout modes
- refactor header of `PopupCall` to contain layout mode buttons

Co-authored-by: SleepySquash <nordnikita@icloud.com> f1bdc04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@kvbykov kvbykov

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
Roadmap
Status: Done
Milestone
0.1.0-alpha.12
Development

Successfully merging this pull request may close these issues.

Add secondary panel modes switches to Call
3 participants
@kvbykov @SleepySquash @krida2000