New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show a descriptive error when unit-tests fail to load requirejs package on some node versions #2699

Merged

davidfirst merged 2 commits into harmony/main from harmony/show-error-on-unit-test-failure

Jun 7, 2020

Member

davidfirst commented May 29, 2020 •

edited

Before, when running the unit-tests on node versions >= 12.16.0, it'd just exit the process without any error.

The root issue is with "rewire" package. See jhnns/rewire#178 for more details.


          show a descriptive error when unit-tests fail to load requirejs packa…

4a5c1fb

…ge on some node versions

AppVeyorBot commented May 29, 2020

❌ Build bit 1.0.10430 failed (commit 2c0f39522e by @davidfirst)


          fix lint, change the error message to indicate that the issue is with…

a3f7ba9

… rewire package

davidfirst merged commit 211248f into harmony/main

davidfirst deleted the harmony/show-error-on-unit-test-failure branch

June 7, 2020 03:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment