Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement(bit-export): improve lane-export performance #6507

Merged
merged 4 commits into from
Oct 2, 2022
Merged

improvement(bit-export): improve lane-export performance #6507

merged 4 commits into from
Oct 2, 2022

Conversation

davidfirst
Copy link
Member

@davidfirst davidfirst commented Oct 1, 2022 •
edited

by sending only the snapped versions to the remote. the algorithm to find them on a lane is the same one used in bit status.
Also, fixed the "getDivergeData" for a new lane, to compare the local-lane vs remote-lane and not versus the main.

@davidfirst davidfirst enabled auto-merge (squash) October 2, 2022 13:18
@GiladShoham GiladShoham merged commit 19e945f into master Oct 2, 2022
@GiladShoham GiladShoham deleted the optimize-export-lane-performance branch October 2, 2022 14:01
@davidfirst davidfirst mentioned this pull request Oct 3, 2022
Merged
davidfirst added a commit that referenced this pull request Oct 3, 2022
@davidfirst
fix(bit-reset): make local-versions on lane be aware of main to not r…
bba7ceb 
…eset it (#6516)

In some cases, due to a recent change (#6507), `bit reset` throws errors while trying to remove exported-versions. 
For now, the code mostly reverts what was done in that PR. Later, a new PR will be created to calculate the local versions more accurately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiladShoham GiladShoham GiladShoham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidfirst @GiladShoham