remove importManyWithAllVersions, refactor some import methods #6542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiladShoham
approved these changes
Oct 13, 2022
…into remove-import-all-ver
… to the client in the previous versions
davidfirst
added a commit
that referenced
this pull request
Oct 18, 2022
In some cases, due to a regression introduced in #6542, the history of main is missing when on a lane. (see the e2e-test to get the exact scenario).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
importManyWithAllVersionsmethod and useimportManyinstead. It made sense for legacy where there was no history, and it was needed to find all versions and fetch them. With harmony, it already traverse the history and bring them.applyVersionof the merge command to not run in parallel, so then it won't runimportManyin parallel.