Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove * from url in Readme #7108

Merged
merged 12 commits into from
Mar 9, 2023
Merged

Remove * from url in Readme #7108

merged 12 commits into from
Mar 9, 2023

Conversation

zakuru
Copy link
Contributor

@zakuru zakuru commented Mar 1, 2023

Proposed Changes

  • update Readme to remove * from quick-start url
  • otherwise the page won't load correctly
  • UI will looks broken on desktop version
  • on mobile view it would show empty content - removing the * won't fix the mobile version completely as the main content will disappear after a quick show. Is the * intended? If yes then the problem would be somewhere else?
    Hope I am not mistaking
    Thanks
Screen_Recording_20230301_200615_Edge.mp4

@benjgil benjgil requested a review from giteden March 1, 2023 19:31
@GiladShoham
Copy link
Member

Thanks for this contribution.
@giteden will review it

@zakuru
Copy link
Contributor Author

zakuru commented Mar 6, 2023

Hi,
The CI passed
Do I need to do anything more to merge it ?
Thanks a lot for taking on this PR

@GiladShoham GiladShoham merged commit b833c72 into teambit:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giteden giteden giteden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zakuru @GiladShoham @giteden