Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pattern help #7803

Merged
merged 8 commits into from
Sep 3, 2023
Merged

Update pattern help #7803

merged 8 commits into from
Sep 3, 2023

Conversation

benjgil
Copy link
Contributor

@benjgil benjgil commented Aug 17, 2023

Proposed Changes

  • ! is a special character in bash terminal if surrounded by double ". So this PR adjusts the pattern help to recommend using single ' when setting a pattern

to exclude, use "!". e.g. "ui/**, !ui/button"
always wrap the pattern with quotes to avoid collision with shell commands.
to enter multiple patterns, separate them by a comma, e.g. 'ui/*, lib/*'
to exclude, use "!". e.g. 'ui/**, !ui/button'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This here aroun the! Should be ' not "

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can see you made the changes, i added some more in the examples so that it's all single '

GiladShoham
GiladShoham previously approved these changes Aug 31, 2023
@GiladShoham GiladShoham enabled auto-merge (squash) August 31, 2023 10:55
@GiladShoham GiladShoham merged commit 5c8dec5 into master Sep 3, 2023
10 of 11 checks passed
@GiladShoham GiladShoham deleted the update-pattern-help branch September 3, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants