Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker - fix docker image tag for node 20 #8215

Merged
merged 2 commits into from Nov 30, 2023
Merged

docker - fix docker image tag for node 20 #8215

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e98e726
docker - fix docker image tag for node 20
GiladShoham Nov 30, 2023
7235362
commented temp docker build
GiladShoham Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 13 additions & 13 deletions .circleci/config.yml
View file
Open in desktop
Expand Up @@ -260,8 +260,8 @@ jobs:
- attach_workspace:
at: ./
- docker_build_and_push:
docker_build_arg_value: "node:20.3.1"
docker_tag_suffix: "-node-20.3.1"
docker_build_arg_value: "node:20.10.0"
docker_tag_suffix: "-node-20.10.0"

# docker_non_root_build:
# machine:
Expand Down Expand Up @@ -1571,10 +1571,10 @@ workflows:
# # requires:
# # - checkout_code
# # - harmony_publish_to_gcloud
# - docker_build_node_18:
# requires:
# - checkout_code
# - harmony_publish_to_gcloud
# # - docker_build_node_18:
# # requires:
# # - checkout_code
# # - harmony_publish_to_gcloud
# - docker_build_node_20:
# requires:
# - checkout_code
Expand All @@ -1583,20 +1583,20 @@ workflows:
# # requires:
# # - checkout_code
# # - harmony_publish_to_gcloud
# - docker_non_root_build_node_18:
# requires:
# - checkout_code
# - harmony_publish_to_gcloud
# # - docker_non_root_build_node_18:
# # requires:
# # - checkout_code
# # - harmony_publish_to_gcloud
# - docker_non_root_build_node_20:
# requires:
# - checkout_code
# - harmony_publish_to_gcloud
# # - server_docker_build:
# # requires:
# # - docker_build
# - server_docker_build_node_18:
# requires:
# - docker_build_node_18
# # - server_docker_build_node_18:
# # requires:
# # - docker_build_node_18
# - server_docker_build_node_20:
# requires:
# - docker_build_node_20
Expand Down