Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not delete ModelComponent objects during export #8415

Merged
merged 2 commits into from
Jan 18, 2024
Merged

do not delete ModelComponent objects during export #8415

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3c1955
do not delete ModelComponent objects during export
davidfirst Jan 17, 2024
820ce45
Merge branch 'master' into export-delete-model-comp
davidfirst Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 1 addition & 9 deletions scopes/scope/export/export.main.runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,15 +492,7 @@ if the export fails with missing objects/versions/components, run "bit fetch --l
return mapSeries(manyObjectsPerRemote, async (objectsPerRemote: ObjectsPerRemoteExtended) => {
const { remote, idsToChangeLocally, componentsAndObjects, exportedIds } = objectsPerRemote;
const remoteNameStr = remote.name;
// on Harmony, version hashes don't change, the new versions will replace the old ones.
const removeComponentVersions = false;
const refsToRemove = await Promise.all(
idsToChangeLocally.map((id) => scope.sources.getRefsForComponentRemoval(id, removeComponentVersions))
);
scope.objects.removeManyObjects(refsToRemove.flat());
// idsToChangeLocally.forEach((id) => {
// scope.createSymlink(id, idsWithFutureScope.searchWithoutScopeAndVersion(id)?.scope || remoteNameStr);
// });

componentsAndObjects.forEach((componentObject) => scope.sources.put(componentObject));

// update lanes
Expand Down