fix(remove), block removal of new aspects that are used by other components #8830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiladShoham
approved these changes
Apr 25, 2024
luvkapur
pushed a commit
that referenced
this pull request
May 3, 2024
…onents (#8830) Otherwise, the components that depend on these removed aspects are trying to load them, find out they don't exists, then trying to import them and throw an error "unable to import". Because these removed aspects are new, there is no easy way to fix this. It's impossible to install them as packages. This PR blocks it unless `--force` flag was used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the components that depend on these removed aspects are trying to load them, find out they don't exists, then trying to import them and throw an error "unable to import".
Because these removed aspects are new, there is no easy way to fix this. It's impossible to install them as packages.
This PR blocks it unless
--forceflag was used.