improvement(import), allow importing main components with wildcard when on a lane #8836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiladShoham
approved these changes
Apr 29, 2024
luvkapur
pushed a commit
that referenced
this pull request
May 3, 2024
…en on a lane (#8836) We used to throw an error suggesting the user to import the components individually. The reason was that when you're on a lane, you probably want to import components from the lane. not main. That's why when the wildcard matches both, lane and main, only the lane are imported. However, if only components from main are matched, it's not very clear whether you really want to import from lane, or your wildcard syntax didn't bring the results you thought it would. With this PR we assume that in this case you do want to import from main so we let you do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to throw an error suggesting the user to import the components individually. The reason was that when you're on a lane, you probably want to import components from the lane. not main. That's why when the wildcard matches both, lane and main, only the lane are imported.
However, if only components from main are matched, it's not very clear whether you really want to import from lane, or your wildcard syntax didn't bring the results you thought it would.
With this PR we assume that in this case you do want to import from main so we let you do that.