Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #has_select? matcher option filters #675

Merged
merged 4 commits into from
Mar 24, 2012
Merged

Refactor #has_select? matcher option filters #675

merged 4 commits into from
Mar 24, 2012

Conversation

grzuy
Copy link

@grzuy grzuy commented Mar 24, 2012

This one addresses #654

  • The partial matching behaviour that had the :options filter was moved to a :included_options filter
  • Change :options filter to match only the exact set of options

@jnicklas
Copy link
Collaborator

I like it, but :included_options doesn't sound very nice to me, can we come up with a better name? Maybe :with_options?

@grzuy
Copy link
Author

grzuy commented Mar 24, 2012

Yep, sounds a bit better!
Just amended the last commit with that change.

jnicklas added a commit that referenced this pull request Mar 24, 2012
@jnicklas
Merge pull request #675 from grzuy/has_select_options_refactor
2ecdeeb 
Refactor #has_select? matcher option filters
@jnicklas jnicklas merged commit 2ecdeeb into teamcapybara:master Mar 24, 2012
@jnicklas
Copy link
Collaborator

Merged, thanks!

@grzuy grzuy mentioned this pull request Mar 24, 2012
Closed
@grzuy grzuy deleted the has_select_options_refactor branch March 6, 2018 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grzuy @jnicklas