Don't parse current_host when building mock session #899

Merged
merged 1 commit into from Dec 3, 2012

Conversation

Projects
None yet
2 participants
@bcardarella
Contributor

bcardarella commented Dec 3, 2012

Because the current_host is now being explicitly set to the host instead
of the full URI (as it was in Capybara 1.x) when URI.parse is being used
the result will always be nil when parsing the host from an incomplete
URI.

Don't parse current_host
Because the current_host is now being explicitly set to the host instead
of the full URI (as it was in Capybara 1.x) when URI.parse is being used
the result will always be `nil` when parsing the host from an incomplete
URI.
@bcardarella

This comment has been minimized.

Show comment Hide comment
@bcardarella

bcardarella Dec 3, 2012

Contributor

This is a bug that is causing issues as the default_host for the mock session object is nil and thus the default_host for the CookieJar is also set to nil.

Contributor

bcardarella commented Dec 3, 2012

This is a bug that is causing issues as the default_host for the mock session object is nil and thus the default_host for the CookieJar is also set to nil.

jnicklas added a commit that referenced this pull request Dec 3, 2012

Merge pull request #899 from bcardarella/master
Don't parse current_host when building mock session

@jnicklas jnicklas merged commit 7137de8 into teamcapybara:master Dec 3, 2012

1 check failed

default The Travis build failed
Details
@bcardarella

This comment has been minimized.

Show comment Hide comment
@bcardarella

bcardarella Dec 3, 2012

Contributor

Woot!

Contributor

bcardarella commented Dec 3, 2012

Woot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment