Don't parse current_host when building mock session #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the current_host is now being explicitly set to the host instead of the full URI (as it was in Capybara 1.x) when URI.parse is being used the result will always be `nil` when parsing the host from an incomplete URI.
|
This is a bug that is causing issues as the |
jnicklas
added a commit
that referenced
this pull request
Dec 3, 2012
Don't parse current_host when building mock session
|
Woot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the current_host is now being explicitly set to the host instead
of the full URI (as it was in Capybara 1.x) when URI.parse is being used
the result will always be
nilwhen parsing the host from an incompleteURI.