Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name 'id' must match pattern '^[a-z]{2,}[a-zA-Z]+$'. (MethodNameCheck) #960

Open
dgroup opened this issue Dec 7, 2018 · 24 comments
Open

Comments

@dgroup
Copy link
Contributor

dgroup commented Dec 7, 2018

Hi Guys,
What is the business purpose of this check for the fields and methods with name equal to id?
This name quite self-explaining.

The same is related to PMD

  • Field id has the same name as a method (AvoidFieldNameMatchingMethodName)
  • Avoid using short method names (ShortMethodName)

Why it can't be added into exclusions?

@0crat
Copy link
Collaborator

0crat commented Dec 7, 2018

@krzyk/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented Dec 7, 2018

@dgroup/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

@krzyk
Copy link
Collaborator

krzyk commented Dec 7, 2018

@dgroup makes sense (considering that we already have #593)

@krzyk
Copy link
Collaborator

krzyk commented Dec 7, 2018

@0crat in

@dgroup
Copy link
Contributor Author

dgroup commented Dec 7, 2018

@krzyk no response from 0crat more than 7 min. Looks like 0crat went into the infinitive loop due to your #960 self-link :)

@0crat 0crat added the scope label Dec 7, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 7, 2018

@0crat in (here)

@krzyk Job #960 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Dec 7, 2018

Bug was reported, see §29: +15 point(s) just awarded to @dgroup/z

@dgroup
Copy link
Contributor Author

dgroup commented Dec 7, 2018

Also, I think the same situation with field/method equal to name.
That's also quite self-explaining.

@0crat
Copy link
Collaborator

0crat commented Jan 24, 2019

The job #960 assigned to @paulodamaso/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@paulodamaso
Copy link
Contributor

@krzyk I believe that it has already been resolved in the linked PRs, what should I do here?

@krzyk
Copy link
Collaborator

krzyk commented Jan 28, 2019

@paulodamaso there wasn't any PR here, the linked issue is for slightly different problem

@paulodamaso
Copy link
Contributor

@krzyk OK,thanks, I'll take a look soon

@paulodamaso
Copy link
Contributor

@0crat refuse

@0crat
Copy link
Collaborator

0crat commented Feb 3, 2019

@0crat refuse (here)

@paulodamaso The user @paulodamaso/z resigned from #960, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link
Collaborator

0crat commented Feb 3, 2019

Tasks refusal is discouraged, see §6: -15 point(s) just awarded to @paulodamaso/z

@0crat
Copy link
Collaborator

0crat commented Feb 3, 2019

@krzyk/z everybody who has role DEV is banned at #960; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Feb 8, 2019

@krzyk/z everybody who has role DEV is banned at #960; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Feb 13, 2019

@krzyk/z everybody who has role DEV is banned at #960; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Feb 18, 2019

@krzyk/z everybody who has role DEV is banned at #960; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Feb 23, 2019

@krzyk/z everybody who has role DEV is banned at #960; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Feb 28, 2019

@krzyk/z everybody who has role DEV is banned at #960; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Mar 6, 2019

@krzyk/z everybody who has role DEV is banned at #960; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Mar 11, 2019

@krzyk/z everybody who has role DEV is banned at #960; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Mar 16, 2019

@krzyk/z everybody who has role DEV is banned at #960; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@yegor256 yegor256 removed the scope label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants