Allow 'id' as a variable name

[mkordas]

Currently Qulice prohibits variable named just 'id', e.g.

final int id = readAttribute("id");

I don't see anything bad in using id as variable name, it is very common and widely accepted.

To overcome it, people use a lot of creativity. I've seen variables named like:

• ide
• ident
• identifier
• attrid
• attribute
• name
• xid

and so on, instead of simple id.

I'd expect id to be allowed as final/non-final local variable names, method parameters, fields and constants (ID). It should be prohibited for catch parameters.

[krzyk]

@yegor256 please take a look at this, are you good with the change?

[yegor256]

@krzyk make sense, I second this

[krzyk]

@davvd valid bug

[davvd]

@davvd valid bug

@krzyk I added bug tag to this ticket

[davvd]

@mkordas thanks for the ticket, your account was topped for 15 mins, payment 56936d48d7717a6a38000067

[krzyk]

@jrdalpra can you work on this?

[jrdalpra]

@krzyk there's any test case to prove the issue?

[jrdalpra]

@mkordas which tool is complaining about the attribute's name? Checkstyle? PMD?

[krzyk]

@jrdalpra you have to create a testcase to prove that it is no longer occurring after the changes

[krzyk]

@davvd assign @jrdalpra please

[mkordas]

@jrdalpra it's Checkstyle complaining

[jrdalpra]

@krzyk @mkordas the problem resides there https://github.com/teamed/qulice/blob/master/qulice-checkstyle/src/main/resources/com/qulice/checkstyle/checks.xml#L312-L315

Can I just pull the changes without a test case and create a puzzle for that test case?

Thanks.

[krzyk]

@jrdalpra without a test case we won't know if it reallyw works

[davvd]

@davvd assign @jrdalpra please

@krzyk done. @jrdalpra the task is yours, please go ahead

[jrdalpra]

@krzyk @davvd there's a PR #615 ready to review. thanks.

[jrdalpra]

@mkordas can you close this issue? Thanks.

[mkordas]

@jrdalpra you need to refer to pull request in at least one message

[jrdalpra]

@mkordas Fixed at PR #621

[mkordas]

@jrdalpra thanks!

[davvd]

@jrdalpra Thanks a lot, I just topped your account for 30 mins, transaction ID AP-91W621665H2212107, total time was 193 hours and 17 mins; +30 added to your rating, at the moment it is: +278