Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to the latest buildpack #7

Closed
wants to merge 1 commit into from

Conversation

duanhongyi
Copy link
Member

No description provided.

@Cryptophobia
Copy link
Member

Cryptophobia commented Oct 25, 2018

Hi @duanhongyi , thank you very much for the awesome contribution! Just a couple of things:

  1. Can you modify the commit messages so they fit our commit-style?
    https://docs.teamhephy.com/contributing/submitting-a-pull-request/#commit-style

  2. Can you rebase from master or merge in master on top of your branch so that travis CI run? I just pushed a commit to master that is supposed to fix travis CI.

Also, do you know of a good way that we can write a test to build slugs for all of these buildpacks and verify that they run correctly? Not sure if this is something we want to do as it will be a time consuming test but it might be good to run as an integration test every once in a while...

@duanhongyi
Copy link
Member Author

OK, I try to upgrade to heroku-18 and submit it all together.

@duanhongyi duanhongyi closed this Oct 25, 2018
@Cryptophobia
Copy link
Member

@duanhongyi , that would be great! Let me know if you need any assistance.

@kingdonb
Copy link
Member

Also, do you know of a good way that we can write a test to build slugs for all of these buildpacks and verify that they run correctly?

That's definitely a feature of the jenkins-jobs "e2e-runner"

Maybe it's time to resurrect that effort, so we can say we've done e2e testing on the next release and report on the results. (I think it would be good to say all the tests are passing, but knowing how bitrot works, I think we've probably got a lot of work ahead of us to get to that point.)

teamhephy/jenkins-jobs@2bcd75f This commit says that's what it does (test all the buildpacks), but there are enough layers of indirection between jenkins-jobs, e2e-runner, workflow-dev-e2e, etc. that I haven't been able to find a list of buildpacks, or some place where they were enumerated.

I've only given it a cursory glance at this point though, so I wouldn't doubt that it's in there...

@kingdonb
Copy link
Member

Actually, here this looks like the place: https://github.com/teamhephy/workflow-e2e/blob/master/tests/buildpacks_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants