Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON serialization of Explanation #75

Closed
lopuhin opened this issue Nov 14, 2016 · 2 comments
Closed

JSON serialization of Explanation #75

lopuhin opened this issue Nov 14, 2016 · 2 comments
Assignees
@lopuhin
Milestone
0.1

Comments

@lopuhin
Copy link
Contributor

lopuhin commented Nov 14, 2016

I think it makes sense to add something like asdict method to Explanation that will return a JSON-serializable object (it will just call attr.asdict(self)).
And also add test that check that it is indeed json-serializable (right now it can have some numpy ints that are not seriazable).
@kmike
Copy link
Contributor

kmike commented Nov 14, 2016 •
edited

Yeah, that'd be a great feature!

Explanation may also have a full-fledged numpy array in TransitionFeatureWeights.

@kmike kmike added this to the 0.1 milestone Nov 14, 2016
@lopuhin lopuhin self-assigned this Nov 15, 2016
@lopuhin
Copy link
Contributor Author

lopuhin commented Nov 15, 2016

Fixed in #84

@lopuhin lopuhin closed this as completed Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lopuhin lopuhin

Labels
None yet
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
2 participants
@kmike @lopuhin