[FEATURE] add context mapping populator #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add GenericContextInterface
- add and rename ContextInterface
* replace generic template type in ContextPopulator more specific
improve dev doc
mike4git
approved these changes
Aug 10, 2023
Closed
jdreesen
reviewed
Aug 18, 2023
| $container->register($propertyContextPopulatorId, ContextMappingPopulator::class) | ||
| ->setArguments([ | ||
| '$targetProperty' => $targetProperty, | ||
| '$sourceProperty' => $sourceProperty ?? $targetProperty, |
There was a problem hiding this comment.
The parameter is named $contextProperty. I fixed it in #48.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the PropertyMappingPopulator I would like to offer a ContextMappingPopulator which populate context properties.