-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] add context mapping populator #47
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c354c89
[FEATURE] add context mapping populator
storbahn e3c7291
[FEATURE] add context mapping populator
storbahn 5f566f8
[FEATURE] add context mapping populator
storbahn 94ab102
removed ContextInterface
mike4git ebc17c9
better reference inside doc
mike4git bbc2c70
* reset default type object for context
mike4git 796db01
removed unused imports
mike4git bfb6fa3
add exceptional test case
mike4git File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
## Development | ||
|
||
### Running tests (incl. code coverage) | ||
|
||
If you want to run the tests (incl. code coverage) you can do so by configuring Phpstorm in the following way: | ||
![phpstorm-settings.png](images/phpstorm-settings.png) | ||
|
||
You can see that we are using the image `pimcore/pimcore:php8.2-debug-latest` here. Of course this could be updated | ||
after a while. | ||
But with this image we can do code coverage by running all tests via phpunit.xml: | ||
![img.png](images/phpstorm-run-configuration.png) |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace Neusta\ConverterBundle\Populator; | ||
|
||
use Neusta\ConverterBundle\Converter\Context\GenericContext; | ||
use Neusta\ConverterBundle\Exception\PopulationException; | ||
use Neusta\ConverterBundle\Populator; | ||
use Symfony\Component\PropertyAccess\PropertyAccess; | ||
use Symfony\Component\PropertyAccess\PropertyAccessorInterface; | ||
|
||
/** | ||
* @template TSource of object | ||
* @template TTarget of object | ||
* @template TContext of GenericContext|null | ||
* | ||
* @implements Populator<TSource, TTarget, TContext> | ||
*/ | ||
final class ContextMappingPopulator implements Populator | ||
{ | ||
/** @var \Closure(mixed, TContext=):mixed */ | ||
private \Closure $mapper; | ||
private PropertyAccessorInterface $accessor; | ||
|
||
/** | ||
* @param \Closure(mixed, TContext=):mixed|null $mapper | ||
*/ | ||
public function __construct( | ||
private string $targetProperty, | ||
private string $contextProperty, | ||
?\Closure $mapper = null, | ||
PropertyAccessorInterface $accessor = null, | ||
) { | ||
$this->mapper = $mapper ?? static fn ($v) => $v; | ||
$this->accessor = $accessor ?? PropertyAccess::createPropertyAccessor(); | ||
} | ||
|
||
/** | ||
* @throws PopulationException | ||
*/ | ||
public function populate(object $target, object $source, ?object $ctx = null): void | ||
{ | ||
if (!$ctx || !$ctx->hasKey($this->contextProperty)) { | ||
return; | ||
} | ||
|
||
try { | ||
$this->accessor->setValue( | ||
$target, | ||
$this->targetProperty, | ||
($this->mapper)($ctx->getValue($this->contextProperty), $ctx) | ||
); | ||
} catch (\Throwable $exception) { | ||
throw new PopulationException($this->contextProperty, $this->targetProperty, $exception); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter is named
$contextProperty
. I fixed it in #48.