This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Port CSV Generation into master #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My JS is a bit rusty
liuziba
suggested changes
Jul 22, 2022
| @@ -10,6 +11,9 @@ import GetReplicationDetailsResponse from './GetReplicationDetailsResponse'; | |||
| import { GetReplicationsResponse } from './GetReplicationsResponse'; | |||
| import UpdateReplicationRequest from './UpdateReplicationRequest'; | |||
| import { ObjectId } from 'mongodb'; | |||
| import fs from 'fs-extra'; | |||
| import path from 'path'; | |||
| const ObjectsToCsv: any = require('objects-to-csv');// no TS support | |||
There was a problem hiding this comment.
Please add @types/objects-to-csv as dev dependency so we get TS support
| }); | ||
| } | ||
| const csv = new ObjectsToCsv(csvRow); | ||
| const configDir = config.util.getEnv('NODE_CONFIG_DIR'); |
There was a problem hiding this comment.
output dir should not be hardcoded here. Either, the request support an output directory/filename, or the response should contain the content of CSV so that the caller can decide which file to save the csv to.
|
@marshyonline do you mind if I close this PR? I have merged my csv branch to master. #106 |
|
Thanks Guys! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kernelogic has a nice branch that generates a CSV for a replication request that is useful for offline deal importing.
The current branch looks to have to many changes than necessary, so I have striped down the core function of this branch, changed where the csv is stored and some logic around creating the storage dir.
All Credit to @kernelogic for this one, I just tidied it up for master