Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterised Test Cases #14 #22

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Parameterised Test Cases #14 #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab8bc4b
Parameterized Junit5 Test Cases
Vish7777 Jan 17, 2024
e9391c1
Parapeterised JUnit5 Test Cases
Vish7777 Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
175 changes: 17 additions & 158 deletions src/test/java/com/techatpark/sjson/JsonTest.java
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

    for (Path path :
            getJSONFiles()) {
            
            Can not we parameterize this ?

Original file line number Diff line number Diff line change
Expand Up @@ -3,131 +3,26 @@
import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.google.gson.JsonElement;
import com.google.gson.JsonParser;
import org.github.jamm.MemoryMeter;
import com.techatpark.sjson.util.TestUtil;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.MethodSource;

import java.io.*;
import java.math.BigInteger;
import java.nio.file.Files;
import java.io.BufferedReader;
import java.io.FileReader;
import java.io.IOException;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.time.Duration;
import java.time.Instant;
import java.util.HashMap;
import java.util.Map;
import java.util.Set;
import java.util.stream.Collectors;
import java.util.stream.Stream;

import org.json.JSONObject;

class JsonTest {

public static final String ANSI_RESET = "\u001B[0m";
public static final String ANSI_RED = "\u001B[31m";
public static final String ANSI_GREEN = "\u001B[32m";
public static final String ANSI_WHITE = "\u001B[37m";

public final ObjectMapper jackson = new ObjectMapper();
public final Json sJson = new Json();

@Test
void testRead() throws IOException {

MemoryMeter meter = MemoryMeter.builder().build();

Object ourJsonObject;
JSONObject orgJSONObject;
JsonNode jacksonJsonNode;
JsonElement gsonObject;

Instant start;

long jacksonsTime, jsonTime, gsonTime, oursTime;
long jacksonsSize, jsonSize, gsonSize, oursSize;

System.out.format( "%60s%45s\n" , "Memory", "Performance");
System.out.format( ANSI_WHITE +"%60s%45s\n"+ ANSI_RESET , "=========", "=========");

System.out.format( "%30s%15s%15s%15s%4s%15s%15s%15s\n" , "File Name","Org Json", "Jackson","Gson","|","Org Json", "Jackson","Gson");
System.out.format(ANSI_WHITE +"%30s%15s%15s%15s%4s%15s%15s%15s\n"+ ANSI_RESET, "----------", "----------", "----------"
,"----------", "|", "----------", "----------", "----------");

for (Path path :
getJSONFiles()) {

// 1. SJson
start = Instant.now();
ourJsonObject = sJson
.read(new BufferedReader(new FileReader(path.toFile())));
oursTime = Duration.between(start, Instant.now()).toNanos();
oursSize = meter.measureDeep(ourJsonObject);


// 2. Org Json
start = Instant.now();
orgJSONObject = new JSONObject(new BufferedReader(new FileReader(path.toFile())));
jsonTime = Duration.between(start, Instant.now()).toNanos();
jsonTime = Math.round(((jsonTime - oursTime) * 100) / jsonTime);
jsonSize = meter.measureDeep(orgJSONObject);

// 3. Jackson
start = Instant.now();
jacksonJsonNode = jackson
.readTree(new BufferedReader(new FileReader(path.toFile())));
jacksonsTime = Duration.between(start, Instant.now()).toNanos();
jacksonsTime = Math.round(((jacksonsTime - oursTime) * 100) / jacksonsTime);
jacksonsSize = meter.measureDeep(jacksonJsonNode);

// 4. Gson
start = Instant.now();
gsonObject = JsonParser.parseReader(new BufferedReader(new FileReader(path.toFile())));
gsonTime = Duration.between(start, Instant.now()).toNanos();
gsonTime = Math.round(((gsonTime - oursTime) * 100) / gsonTime);
gsonSize = meter.measureDeep(gsonObject);

// 3. SJson with Jackson
String reversedJsonText = jackson
.writeValueAsString(ourJsonObject);

Assertions.assertEquals(jacksonJsonNode,
jackson.readTree(new StringReader(reversedJsonText)),
"Reverse JSON Failed for " + path);
System.out.format("%33s%20s%20s%20s%10s%20s%20s%20s\n",
ANSI_RESET + path.getFileName(),
getSizeDisplay(jsonSize,oursSize),
getSizeDisplay(jacksonsSize,oursSize),
getSizeDisplay(gsonSize,oursSize),
ANSI_WHITE +"|",
getTimeDisplay(jsonTime),
getTimeDisplay(jacksonsTime),
getTimeDisplay(gsonTime)
);
}
}

/**
* Test Illegal JSON Texts.
* @throws IOException
*/
@Test
void testIllegal() throws IOException {
try (Stream<Path> stream
= Files.list(Paths.get("src/test/resources/illegal"))) {
stream
.filter(path -> !Files.isDirectory(path))
.forEach(path -> {

Exception exception = Assertions.assertThrows(IllegalArgumentException.class, () -> {
sJson.read(new FileReader(path.toFile()));
});

});
}
}

/**
* Test Plan.
Expand All @@ -137,13 +32,13 @@ void testIllegal() throws IOException {
* 3. Compare Both JSON Nodes and verify they are equal.
* @throws JsonProcessingException
*/
@Test
void testGetJsonText() throws IOException {
@ParameterizedTest
@MethodSource("jsonFilesProvider")
void testGetJsonText(Path path) throws IOException {

Object sJsonObject ;

for (Path path :
getJSONFiles()) {

// This is our Code
sJsonObject = sJson
.read(new BufferedReader(new FileReader(path.toFile())));
Expand All @@ -162,7 +57,7 @@ void testGetJsonText() throws IOException {
+ path);
}
}
}


@Test
void testNullJsonText() {
Expand All @@ -177,51 +72,15 @@ void testNullJsonText() {

Assertions.assertEquals(nullJson, nullSJson);
}
/**
* Utility to get Json Files from Test Resources directory.
* @return Set of Paths
* @throws IOException
*/
private Set<Path> getJSONFiles() throws IOException {
String baseFolder = System.getenv("SJSON_LOCAL_DIR") == null ? "src/test/resources/samples" :
System.getenv("SJSON_LOCAL_DIR");
try (Stream<Path> stream = Files.list(Paths.get(baseFolder))) {
return stream
.filter(file -> !Files.isDirectory(file))
.collect(Collectors.toSet());
}
}

/**
* Get Timing in a Color Coded Format.
* @param time
* @return time as text
* Provides paths to JSON files for parameterized tests.
*
* @return Stream of paths to JSON files
* @throws IOException if there is an issue listing files
*/
private String getTimeDisplay(final long time) {
StringBuilder builder = new StringBuilder();
if(time < 0) {
builder.append(ANSI_RED);
}
else {
builder.append(ANSI_GREEN);
}
return builder.append(time).toString();
private static Set<Path> jsonFilesProvider() throws IOException {
return TestUtil.getJSONFiles();
}

/**
* Get Size in a Color Coded Format.
* @param size
* @return size as text
*/
private String getSizeDisplay(final long size,final long ourSize) {
StringBuilder builder = new StringBuilder();
long gap = size-ourSize;
if(gap < 0) {
builder.append(ANSI_RED);
}
else {
builder.append(ANSI_GREEN);
}
return builder.append(gap).toString();
}
}
39 changes: 14 additions & 25 deletions src/test/java/com/techatpark/sjson/JsonValidationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,46 +1,35 @@
package com.techatpark.sjson;


import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.MethodSource;

import java.io.FileReader;
import java.io.IOException;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;

import java.util.stream.Stream;

class JsonValidationTest {




public final Json sJson = new Json();


/**
* Test Illegal JSON Texts.
*
* @throws IOException
*/
@Test
void testIllegal() throws IOException {
try (Stream<Path> stream
= Files.list(Paths.get("src/test/resources/illegal"))) {
stream
.filter(path -> !Files.isDirectory(path))
.forEach(path -> {

Exception exception = Assertions.assertThrows(IllegalArgumentException.class, () -> {
sJson.read(new FileReader(path.toFile()));
});

});
}
@ParameterizedTest
@MethodSource("illegalJsonPaths")
void testIllegal(Path path) {
Exception exception = Assertions.assertThrows(IllegalArgumentException.class, () -> {
sJson.read(new FileReader(path.toFile()));
});
}




}
private static Stream<Path> illegalJsonPaths() throws IOException {
return Files.list(Paths.get("src/test/resources/illegal"))
.filter(path -> !Files.isDirectory(path));
}
}
Loading