Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be/#288 MyPage API 수정 #289

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Be/#288 MyPage API 수정 #289

merged 2 commits into from
Nov 10, 2023

Conversation

baekhangyeol
Copy link
Collaborator

🛠️ 변경사항

GetMyPageResponse에서 member의 id를 리턴하도록 변경
테스트 코드 : 바뀐 GetMyPageResponse에 맞게 수정

☝️ 유의사항



👀 참고자료



❗체크리스트

  • 하나의 메소드는 최소의 기능만 하도록 설정했나요?
  • 수정 가능하도록 유연하게 작성했나요?
  • 필요 없는 import문이나 setter 등을 삭제했나요?
  • 기존의 코드에 영향이 없는 것을 확인하였나요?

@baekhangyeol baekhangyeol self-assigned this Nov 9, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Unit Test Results

85 tests  ±0   85 ✔️ ±0   3s ⏱️ -2s
17 suites ±0     0 💤 ±0 
17 files   ±0     0 ❌ ±0 

Results for commit 2349b3d. ± Comparison against base commit 2327e10.

@baekhangyeol baekhangyeol linked an issue Nov 9, 2023 that may be closed by this pull request
[refactor] MyPage API 수정 #288
Closed
2 tasks
kimhalin
kimhalin approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@kimhalin kimhalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youKeon
Copy link
Collaborator

youKeon commented Nov 9, 2023

LGTM👍

@baekhangyeol baekhangyeol merged commit 89d217b into feature Nov 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimhalin kimhalin kimhalin approved these changes

@youKeon youKeon youKeon approved these changes

Assignees

@baekhangyeol baekhangyeol

Labels
리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[refactor] MyPage API 수정
3 participants
@baekhangyeol @youKeon @kimhalin