Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Completed-By Column To Google Spreadsheets #15

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from

Conversation

zapdos26
Copy link
Contributor

@zapdos26 zapdos26 commented Oct 22, 2019

Adds #14 for both usernames and userids
Along with that, it fixes an error regarding how map() is not a function of getChores()

utilities/getChores.js Outdated Show resolved Hide resolved
utilities/markChoreDone.js Show resolved Hide resolved
utilities/markChoreDone.js Outdated Show resolved Hide resolved
utilities/markChoreDone.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
utilities/getChores.js Show resolved Hide resolved
utilities/markChoreDone.js Outdated Show resolved Hide resolved
utilities/markChoreDone.js Show resolved Hide resolved
utilities/markChoreDone.js Outdated Show resolved Hide resolved
@ddbruce
Copy link
Member

ddbruce commented Oct 23, 2019

@zapdos26 how was this code tested?

@zapdos26
Copy link
Contributor Author

I literally ran the bot in a slack workspace and setup example values in a spreadsheet. Is there something more I should do?

@ddbruce
Copy link
Member

ddbruce commented Oct 23, 2019

Nope, I was just wondering. For a feature like this where we're initially doing a PR to dev, a quick note about prior testing would be appreciated. I trust the code wasn't just written willy-nilly haha

@zapdos26
Copy link
Contributor Author

Ok

@justetz
Copy link
Contributor

justetz commented Nov 3, 2019

Hey @ddbruce and @zapdos26, where does this PR currently stand?

@ddbruce
Copy link
Member

ddbruce commented Nov 3, 2019

I thought we had discussed not merging it. I actually mentioned this to @zapdos26 because I feel out-of-the-loop regarding this particular feature.

@zapdos26
Copy link
Contributor Author

zapdos26 commented Nov 3, 2019

Since that discussion, I find a possible reason to add it.
If we want to implement #18, this would be great to have instead of searching through slack messages and extracting.
Along with that, from my understanding of the cron job for heads up (which I believe is more frequent than daily), the board will be when the jobs are complete. So this is an easy way to calculate if jobs are complete.

@CKegel
Copy link

CKegel commented Feb 1, 2023

@ddbruce I'm currently working on implementing chore completion in headsup, and having even a completed column would be quite useful. I'd be happy to re-implement or make the required changes so this could possibly be merged.

@ddbruce
Copy link
Member

ddbruce commented Feb 4, 2023

@CKegel sounds good. What do you need from us?

@CKegel
Copy link

CKegel commented Feb 5, 2023

Ideally we could merge this branch, and then I'd add to it, so that when chores are sent to headsup, it includes the completed by data. Additionally the chore data would be sent to headsup whenever a chore is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants