-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds elasticsearch logger #9
Conversation
a526068
to
8976c96
Compare
Added healthcheck command to Dockerfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather NOT use docker-wait. If you can, use the HEALTHCHECK
I've added As far as I can tell doing this merely adds a property to the container metadata (health status), it doesn't delay execution of the container So we still need the polling script triggered by docker-compose to get a local development environment set up with |
According to this, it should: docker/compose#4163 (comment) |
Ok I'll try to get that method working |
Since you have it working, I don't want to stop you merging this PR in. If you envision this being a sizeable chunk of work, it's better to factor that in a different PR. |
8976c96
to
132d743
Compare
reverted docker compose to v2.1 so could remove |
132d743
to
43cf2be
Compare
7dda598
to
5d98786
Compare
No description provided.