Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: redo the text and search components based on React Native Paper #1449

Merged
merged 48 commits into from
Jun 11, 2024
Merged

fix: redo the text and search components based on React Native Paper #1449

merged 48 commits into from
Jun 11, 2024

Conversation

paulschreiber
Copy link
Member

@paulschreiber paulschreiber commented May 31, 2024 •
edited
Loading

Description

Redo the text and search components based on React Native Paper

  • remove old SearchBar and FormTextArea components
  • create new TextInputComponent
  • eliminates our own code for adding search icons and clearing searches
  • remove some duplicate string entries for project name/description/search
  • refactored the ProjectForm code to get rid of SharedFormComponents (which wasn't shared) and EditHeader (which never appeared)
  • use consistent spacing on lists of checkboxes and switches
  • remove nonfunctional download link from project settings

Courtney approved the use of the rounded corner search field.

Related Issues

Corresponding Select box fix #1443
Addresses #688.

@paulschreiber paulschreiber mentioned this pull request Jun 6, 2024
Closed
1 task
@paulschreiber paulschreiber force-pushed the fix/text branch 2 times, most recently from f32ffb1 to d6252b2 Compare June 7, 2024 18:45
knipec
knipec reviewed Jun 7, 2024
View reviewed changes
dev-client/src/components/IntervalForm.tsx Outdated Show resolved Hide resolved
dev-client/src/components/ListFilter.tsx Outdated Show resolved Hide resolved
dev-client/src/components/SiteNoteForm.tsx Outdated Show resolved Hide resolved
dev-client/src/constants.ts Outdated Show resolved Hide resolved
dev-client/src/components/inputs/TextInput.tsx Show resolved Hide resolved
dev-client/src/screens/CreateProjectScreen/components/ProjectForm.tsx Show resolved Hide resolved
dev-client/src/screens/CreateProjectScreen/components/ProjectForm.tsx Show resolved Hide resolved
dev-client/src/screens/HomeScreen/components/MapSearch.tsx Outdated Show resolved Hide resolved
dev-client/src/screens/SiteSettingsScreen/SiteSettingsScreen.tsx Show resolved Hide resolved
dev-client/src/screens/SiteTransferProjectScreen/components/ListHeader.tsx Outdated Show resolved Hide resolved
@paulschreiber paulschreiber requested a review from knipec June 7, 2024 21:35
@paulschreiber paulschreiber force-pushed the fix/text branch 2 times, most recently from 88f05ed to 9feabbb Compare June 10, 2024 20:46
paulschreiber and others added 26 commits June 10, 2024 18:32
@paulschreiber
fix: remove duplicate project form label text
b040bee
@paulschreiber
fix: use opaque color for text field background
55553eb 
fixes problem when two transparent colors were stacked resulted in a blended color
@paulschreiber
fix: rework FormInput types to work with new TextInput (using React N…
9ca7389 
…ative Paper)
@paulschreiber
fix: rework ProjectForm to use new TextInput fields
98c22db 
- remove unused EditHeader
- refactor away SharedFormComponents (which wasn’t shared)
@paulschreiber
fix: deduplicate projects search placeholder
c3cf240
@paulschreiber
fix: use label for site name text field
62458e3
@paulschreiber
fix: standardize site name field
bbf8fbf
@paulschreiber
fix: avoid null deref on project input screen
8d63474
@paulschreiber
fix: update prop passing on FreeformTextInput
4315da0
@paulschreiber
refactor: use react native paper searchbar
b16beb2
@paulschreiber
fix: avoid null deref on ProjectSitesScreen
367a7db
@paulschreiber
fix: remove no-op padding style
5d0776d
@paulschreiber
fix: rework SiteNoteForm to use new FormInput
8b38977
@paulschreiber
test: update test snapshots
c594649
@paulschreiber
fix: clean up imports after rebase
a4f2b3a
@paulschreiber
fix: move stylesheet to bottom of ListFIltertsx
42b0d80
@paulschreiber
fix: use px for spacing on interval form
e9d83d4
@paulschreiber
fix: use px for spacing on ListHeader
56048ae
@paulschreiber
fix: restore color cursor to notes field on Android
2ff7a81
@paulschreiber
fix: remove underline from site notes field
20fb782
@paulschreiber
chore: update snapshots
7be0cf8
@paulschreiber @knipec
Update dev-client/src/components/IntervalForm.tsx
e502409 
Co-authored-by: Carissa Knipe <carissa@techmatters.org>
@paulschreiber
fix: rename searchFilterStyles to searchBarStyles
65d3bb6
@paulschreiber
fix: add missing Radio and MEASUREMENT_UNITS imports
3676b7b
@paulschreiber
fix: use px units for Box margins
dce89e1
@paulschreiber
refactor: move SWITCH_PADDING contants to theme
1c26adc
@paulschreiber paulschreiber merged commit 0894a9c into main Jun 11, 2024
9 checks passed
@paulschreiber paulschreiber deleted the fix/text branch June 11, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knipec knipec knipec approved these changes

@tm-ruxandra tm-ruxandra Awaiting requested review from tm-ruxandra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulschreiber @knipec