-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Export buttton only writes the explicit settings, and converts to selected color space #320
Conversation
…ected color space
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I was passing any unmapped property from Daisy/Skeleton in case there was something you might still want applied (font-face, border radius, etc). I later decided this isn't great, but haven't had a chance to clean this up. In that same work, I plan to I don't have much time right now, but I noticed with the new copy it does not include Before{
"light": {
"color-scheme": "light",
"primary": "oklch(49.12% 0.3096 275.75)",
"secondary": "oklch(69.71% 0.329 342.55)",
"secondary-content": "oklch(98.71% 0.0106 342.55)",
"accent": "oklch(76.76% 0.184 183.61)",
"neutral": "#2B3440",
"neutral-content": "#D7DDE4",
"surface-100": "oklch(100% 0 0)",
"surface-200": "#F2F2F2",
"surface-300": "#E5E6E6",
"surface-content": "#1f2937"
},
"dark": {
"color-scheme": "dark",
"primary": "oklch(65.69% 0.196 275.75)",
"secondary": "oklch(74.8% 0.26 342.55)",
"accent": "oklch(74.51% 0.167 183.61)",
"neutral": "#2a323c",
"neutral-content": "#A6ADBB",
"surface-100": "#1d232a",
"surface-200": "#191e24",
"surface-300": "#15191e",
"surface-content": "#A6ADBB"
}
} After{
"light": {
"primary": "hsl(257.4075 100% 50%)",
"secondary": "hsl(310.4453 100% 50%)",
"accent": "hsl(173.4835 100% 42.1865%)",
"neutral": "hsl(214.2857 19.6262% 20.9804%)",
"surface-100": "hsl(180 100% 100%)",
"surface-200": "hsl(0 0% 94.902%)",
"surface-300": "hsl(180 1.9608% 90%)"
},
"dark": {
"primary": "hsl(234.8208 100% 72.6713%)",
"secondary": "hsl(313.3209 100% 66.1653%)",
"accent": "hsl(173.7346 100% 40.1728%)",
"neutral": "hsl(213.3333 17.6471% 20%)",
"surface-100": "hsl(212.3077 18.3099% 13.9216%)",
"surface-200": "hsl(212.7273 18.0328% 11.9608%)",
"surface-300": "hsl(213.3333 17.6471% 10%)"
}
} |
Actually I just looked in my Strava / Github analysis projects and we don't have to be explicit for |
Added |
Thanks @dimfeld. I'll probably remove "Copy Full Theme" in the future once border radius theming is implemented as I can't think of a good reason to keep it (and reduce confusion) |
Resolves #318
I also added a "Copy Full Theme" menu item which retains the old behavior. Seems like it's kind of inconsistent though... when you start from a Skeleton theme then you seem to get the full exported theme, but when you start from a Daisy theme then the export is much shorter. I figure you will have a good idea of why that is :) Or maybe the skeleton themes are just including a whole bunch of variables that aren't used? Not totally sure. We may want to just remove this button.
This also changes the list of ColorFields to be data-driven since I was already creating an array of theme keys anyway as part of this.