-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging to Master #462
Staging to Master #462
Conversation
…ckout-3.x chore(deps): update actions/checkout action to v3
…up-node-3.x chore(deps): update actions/setup-node action to v3
…and-commit-9.x chore(deps): update endbug/add-and-commit action to v9
…-on-click refactor(#460) - Add Link to OSM Pump Editor on Pump Tooltip
Thanks for this really rigorous and even so quick review an PR @vogelino @dnsos @ff6347! I've tested the deploy preview and found three things that could be improved – UX- and design-wise:
Please see the two screenshots attached and let me know what you think. |
Good catch with changing the view type. The overlay disappears when moving the map but having a close button would be more explicit. About the alignment: I actually like it on the right hand side. It's like you enter top left and leave bottom right. |
Hi @julizet and thx for your feedback! I agree with @ff6347 that the right alignment is well suited as last element on the tooltip. To be honest, this wasn't the reason why I did it though, much more it was because it was way easier to implement this way. Making it left aligned would require additional work. I am now also closing the tooltip every time the mouse clicks outside of the tooltip. This solves every problem mentioned above. It makes the X obsolete I think. Here is the PR: #466 |
…p-refactor Refactor/pump tooltip refactor
@tordans the preview URL is this one: https://deploy-preview-462--giessdenkiez.netlify.app/ |
I agree with that -> clicking outside of the tooltip is a lightweight UX-solution. Let's skip this left-alignment in order to save dev capacities. If @tordans doesn't has anx further comments / feedback we are good to merge into main, IMHO |
Perfect @julizet. Thx for your feedback! I will merge it now. |
Looks great! Thanks! Will Twitter via |
It's live! 🟢 |
This PR merges the PR #460 into Master and thereby releases the OSM Editor Link in the Tooltips.