This repository has been archived by the owner on Jul 18, 2020. It is now read-only.
Fix and improvement to thrush #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting; I was wondering if anyone would actually use this. =) Thanks. |
technomancy
added a commit
that referenced
this pull request
Mar 19, 2013
Fix and improvement to thrush
|
Released this as 0.1.1. |
|
I'm working on a toolchain of composable tasks and higher-order tasks to handle releasing, bundling, uploading to S3, adding a link to the bundle to a Wiki page, etc. I'll use thrush as the backbone that connects these into the complete release procedure. Thanks for realeasing 0.1.1! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial commit has some bugs (
partialhas arguments reversed, the initial call ofapply-taskis missing an argument) and is not fully in line with thedotask and the->operator (doesn't allow more arguments besides the threaded one, doesn't use comma-separated argument groups). I propose to fix and improve the task with this commit. I also took the liberty to rewrite the docstring by copy-pasting the description fromdefproject, which seems more expressive, and a relevant sentence from thedotask.