Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Command line arguments ignored for aliases #1913

Closed
binarykitchen opened this issue Jun 5, 2015 · 2 comments
Closed

[Bug] Command line arguments ignored for aliases #1913

binarykitchen opened this issue Jun 5, 2015 · 2 comments
Assignees
Labels

Comments

@binarykitchen
Copy link

When I do a lein redline-rpm --brand='*', which will call lein build internally whose alias will be resolved into ["shell" "npm" "run" "build"] then I can see that the brand argument is missing.

I guess leiningen is not passing on any arguments to the alias when called.

Here an extract of our project.clj

  ; Prep-tasks are called on clojure compilation which is needed for lein run or lein jar
  :prep-tasks
  [ "build"
    "javac"
    "compile"]

  :aliases
  { "build"         ["shell" "npm" "run" "build"]
    "test"          ["shell" "npm" "run" "test"]
    "test:unit"     ["shell" "npm" "run" "test:unit"]
    "deps"          ["do" "deps" ["shell" "npm" "i"]]

  ; A trick to adjust environment before running commands, see
  ; https://github.com/hyPiRion/lein-shell/issues/17
  :shell
  {:commands
    { "npm" {:default-command "npm"}}}

How can I force leiningen to pass on arguments further to npm?

@hypirion hypirion added the bug label Nov 3, 2015
@hypirion hypirion self-assigned this Nov 23, 2015
hypirion added a commit that referenced this issue Nov 23, 2015
Afaik there's no need to not pass in a project-like thing as first
argument for tasks.
@binarykitchen
Copy link
Author

thanks!

hypirion added a commit to hypirion/lein-shell that referenced this issue Nov 24, 2015
So that people can use lein-shell immediately by just bumping dependency
number to 0.4.2.
@hypirion
Copy link
Collaborator

@binarykitchen: No problem, and sorry about the delay here. I've also pushed out a fix in lein-shell, so changing the lein-shell version to 0.4.2 should now work on any version of leiningen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants