Allow multiple repl task profiles #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserve any metadata on profile maps specified in project.clj files.
hugoduncan
force-pushed
the
feature/add-task-profile-meta
branch
from
5d84911
to
d159ded
Compare
Function to return a sequence of profile keywords for all project profiles with metadata matching a predicate.
The :repl profile does not compose well when specified in both project.clj and profiles.clj files. Merge all profiles with ^:repl metadata in the repl task. This allows multiple profiles to be applied for the repl task.
hugoduncan
force-pushed
the
feature/add-task-profile-meta
branch
from
d159ded
to
e946ad1
Compare
|
Sorry for the delay here. I like the idea behind this; it definitely makes the specification more flexible. Can you confirm that this would work for user-specified |
|
Just tested to confirm that the case in question above works, so this looks good. |
technomancy
added a commit
that referenced
this pull request
Oct 12, 2014
Allow multiple repl task profiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The :repl profile does not compose well when specified in both
project.clj and profiles.clj files.
Merge all profiles with ^:repl metadata in the repl task. This allows
multiple profiles to be applied for the repl task.
Note that this could be done for other task specific profiles (e.g. test).