[PoC] Preserve :tag's safely in eval-in-project #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #2695
Related #2696
This PR attempts to enhance
eval-in-projectwith the ability to preserve metadata:tagforms in a backwards-compatible way. Please consider it a proof-of-concept at the moment, I would like some feedback before it's considered ready.It seems less risky than previous attempts (discussed here).
The basic idea is to only
*print-meta* truea form if you can guarantee all metadata is safe to print in a form (by stripping all but:tagmetadata), otherwise point the user to reasons why:taginformation was thrown away (eg., vars).There's also a few other ideas for enhancements piled in that I found while I was developing, happy to move them out if needed.