This repository has been archived by the owner on Jul 18, 2020. It is now read-only.
Fixes and improvements to the Racket code #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Either by calling Racket on the file, or running it directly.)
`=' can't work on pairs; proper range testing. This makes it actually playable...
Since this is the preferred style in Racket code.
There's no point in sending it the input and calling it after showing the board -- much simpler to do it all in it.
Use `rand-pos' to abstract over postion making, and use a loop instead of folding over an ignored list.
In general, we try to avoid generic values like lists (as used in Scheme/Lisp) and hashes (as used in JS/Ruby/etc) when we have a specific type.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed some bugs and made some improvements, but I tried to do so while keeping it close to the original.