Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better ring detection #315

Merged
merged 5 commits into from
Mar 11, 2024

Conversation

iranl
Copy link
Collaborator

@iranl iranl commented Mar 4, 2024

Closes #215

@technyon
Copy link
Owner

technyon commented Mar 5, 2024

@iranl Were you able to test this? I'm glad they finally updated the opener API documentation, but from what I observed a beacon for a lock state update was received, but the lock state was the same as before.

If not tested, could you post a binary in #215 for testing?

@iranl
Copy link
Collaborator Author

iranl commented Mar 5, 2024

I don't own an Opener so I am not able to test this myself.

That is why I asked @bklaesener in #215 to test the results and report back.

I don't believe the locked lock state update logic becomes redundant because of this, because that will still detect the ring when both RTO and continuous mode are disabled.

The new code should signal a ring when the door opens as the result of a ring while RTO or continuous mode is active. This matches with the lock state changing to open and the trigger changing to manual (as reported by @bklaesener)

I've linked to the binary created through the GitHub PR actions/check (release_assets) in #215. I could upload that binary there but from a security perspective I prefer users get the binary that GitHub creates, so everyone can be sure there is no tampering with the binary (you know for sure the binary is build using master + the PR and nothing else).

@iranl iranl marked this pull request as ready for review March 10, 2024 07:52
@iranl
Copy link
Collaborator Author

iranl commented Mar 10, 2024

Note: lock/state will not reflect ring anymore. As such a minor breaking change that should be reflected in change log and probably shared on Discord.

lock/binaryRing will show ring for 2 sec after ring (both locked and open) after which it will change back to standby. Used by the HA ring binary sensor.

lock/ring will publish ring after ring while RTO or continuous mode is active and ringlocked when RTO and continuous mode are both inactive. Used by the HA ring event sensor.

Will update the readme to reflect.

@iranl iranl marked this pull request as draft March 10, 2024 08:01
@iranl iranl marked this pull request as ready for review March 10, 2024 19:41
@technyon technyon merged commit aaa492b into technyon:master Mar 11, 2024
1 check passed
@iranl iranl deleted the fix-continuous-mode-ring-detection branch March 16, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opener - ring detect sensor not working
2 participants