-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better ring detection #315
Better ring detection #315
Conversation
I don't own an Opener so I am not able to test this myself. That is why I asked @bklaesener in #215 to test the results and report back. I don't believe the locked lock state update logic becomes redundant because of this, because that will still detect the ring when both RTO and continuous mode are disabled. The new code should signal a ring when the door opens as the result of a ring while RTO or continuous mode is active. This matches with the lock state changing to I've linked to the binary created through the GitHub PR actions/check (release_assets) in #215. I could upload that binary there but from a security perspective I prefer users get the binary that GitHub creates, so everyone can be sure there is no tampering with the binary (you know for sure the binary is build using master + the PR and nothing else). |
Note:
Will update the readme to reflect. |
Closes #215