Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: improve style for mobile view #393

Merged
merged 11 commits into from
Jun 7, 2024
Merged

Conversation

duhow
Copy link
Contributor

@duhow duhow commented Jun 5, 2024

Make the website more mobile-friendly - note the main menu needs another change (not to do on this PR).

Changes

  • ❗ In cb09e96 , the unused code style from original CSS style is removed.
  • Added .adapt class to <form> , this way we skip the page Access Level Configuration, which currently has an acceptable view layout for phone.
  • 🆕 Inputs are set to display: block, underneath the previous cell.
  • In fa61c0c , update ConfirmationHtml function to use HeaderHtml function, this way, when the user updates configuration, it will use style CSS, and the page won't render as a blank website.

NOTE: While I separated the content into a new file style.css, bear in mind this is not integrated into build process.
I am using https://www.freeformatter.com/css-minifier.html to minify the CSS file and copying the content back again to the header file as const. You can request to delete the new style.css file if you wish.

@iranl
Copy link
Collaborator

iranl commented Jun 5, 2024

I don't have a problem with adding the unminified style.css, but would not place it in src. I would put it somewhere on the top level, maybe add a resources dir or something where how-to-flash.txt and boot_app0.bin could also live.

@duhow
Copy link
Contributor Author

duhow commented Jun 5, 2024

Mmmm.. what about include ? If not, resources sounds also ok.

@iranl
Copy link
Collaborator

iranl commented Jun 5, 2024

include has special purpose in platformio, so I wouldn't use it for other purposes

@iranl iranl added enhancement New feature or request labels Jun 5, 2024
@iranl iranl modified the milestone: 8.35 Jun 5, 2024
@duhow
Copy link
Contributor Author

duhow commented Jun 6, 2024

@iranl check now? 🙏🏻

@technyon technyon merged commit bf3400b into technyon:master Jun 7, 2024
2 checks passed
@duhow duhow deleted the css-mobile branch July 3, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants