This repository has been archived by the owner on May 11, 2021. It is now read-only.
Update homepage image #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added myself as a contributor underneath the credits section
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
dvidsilva
approved these changes
Oct 25, 2018
|
@YourMobileGeek Could we optimize the image for performance before it gets merged? Making it a smaller width and making it ~500KB in size would be best. We are adding an integration that will do this automatically but for now, that would be ideal! |
FrancesCoronel
suggested changes
Oct 25, 2018
|
@fvcproductions Sounds good, I can go ahead and look into making it a smaller width, it regards to optimization to 500kb is there a workaround around for this you would suggest? |
|
I usually use tinypng.com |
|
@fvntr oh wow, yea I definitely overlooked that haha. I was thinking that you wanted to use another integration for the time being. Thanks! I'll go ahead and switch out this image and do a pull request. |
added 2 commits
October 26, 2018 01:32
…Geek/website into update_homepage_image
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ahead and switched out the homepage image provided through Google Photos for the Techqueria website.
✅️ By submitting this PR, I have verified the following