Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][.NETCore] Removal of Code- Behind- Generation #929

Closed

Conversation

SabotageAndi
Copy link
Contributor

#resolves #824

@SabotageAndi SabotageAndi changed the base branch from master to DotNetCore_MigrateToXUnit September 5, 2017 07:54
@gasparnagy
Copy link
Contributor

@SabotageAndi What did you do in this PR exactly? It is hard to get it from the changes...

@SabotageAndi
Copy link
Contributor Author

I integrated your PoC from https://github.com/gasparnagy/SpecFlow.xUnitAdapter into the SpecFlow solution and made changes that where needed to get the scenarios executed without codebehind file.
Next step for me was also use this for the projects that where generated and run during the tests.
If this works again, I would refactor the solution to a more generic one so that the work for other test runner is easier.

@SabotageAndi SabotageAndi changed the title [WIP]|.NETCore] Removal of Code- Behind- Generation [WIP][.NETCore] Removal of Code- Behind- Generation Sep 5, 2017
@gasparnagy
Copy link
Contributor

Ah good. Did you get it working locally? (There are couple of ideas how to improve the PoC, I guess the best would be to make these improvements here. Or at least we need to sync the changes.

@SabotageAndi
Copy link
Contributor Author

Getting it to work was not a big problem. The rest around made more headaches.

@SabotageAndi
Copy link
Contributor Author

To continue forward with this PR, there has to be made some enhancement to the test project setup code (solution file, nuget restore, nuget feed, ...).
I wrote this already for the SpecFlow+Runner. I am working to refactor this code to make it reusable in SpecFlow & SpecFlow+Runner.

@SabotageAndi
Copy link
Contributor Author

The test project setup code is now open sources in this repo: https://github.com/techtalk/SpecFlow.TestProjectGenerator
It should be "integrated" in this repo via subtree (https://help.github.com/articles/about-git-subtree-merges/).

The API is similar to the existing ones. So swapping it out should be not that big problem.
The added changes are written mostly for the SpecFlow+Runner tests. So it could be that there is additional work needed for other runners.

@gasparnagy
Copy link
Contributor

@SabotageAndi great! (although the name SpecFlow.TestProjectGenerator is pretty confusing for me, I have to admit.)

@robertcoltheart
Copy link
Contributor

What's the progress on this? Can we get this merged and released?

@SabotageAndi
Copy link
Contributor Author

closing PR because we won't follow this idea for the first release of .NET Core support.

@SabotageAndi SabotageAndi deleted the DotNetCore_RemoveCodeGeneration branch July 2, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants