Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline CSS #170

Closed
shushugah opened this issue Oct 7, 2019 · 5 comments
Closed

Inline CSS #170

shushugah opened this issue Oct 7, 2019 · 5 comments
Assignees
@saraheisa
Labels
good first issue hacktoberfest

Comments

@shushugah
Copy link
Member

Similar to this commit, inline the CSS, so that it is not a blocking resource, or a separate HTTP call. Our CSS is extremely light weight as is.

https://github.com/shushugah/shushugah.github.io/commit/416b8d386993e8ed2f5f73fa575581c31ccf43e9
@saraheisa
Copy link
Contributor

@shushugah can I work on this one?

@shushugah shushugah assigned shushugah and saraheisa and unassigned shushugah Oct 10, 2019
@shushugah
Copy link
Member Author

These are the three 3 blocking files, normalize.css, main.css and the jquery https://developers.google.com/speed/pagespeed/insights/?url=https%3A%2F%2Ftechworkerscoalition.org

@saraheisa
Copy link
Contributor

@shushugah can you please mention any resources for that capture tag you're using in that commit?

@shushugah
Copy link
Member Author

Sure thing! I learnt about it first here, let me know if you have any more questions and thank you for picking this up!

https://www.sitepoint.com/inline-css-in-jekyll/

@saraheisa
Copy link
Contributor

very interesting!

@saraheisa saraheisa mentioned this issue Oct 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saraheisa saraheisa

Labels
good first issue hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shushugah @saraheisa