-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inline CSS #175
Merged
shushugah
merged 9 commits into
techworkersco:develop
from
saraheisa:prosarahgamal-patch-1
Oct 14, 2019
Merged
inline CSS #175
shushugah
merged 9 commits into
techworkersco:develop
from
saraheisa:prosarahgamal-patch-1
Oct 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release-20191010
Inline CSS so it doesn't block resources
defer jquery js file request so it doesn't block resources
solving issue #170 |
shushugah
requested changes
Oct 13, 2019
shushugah
reviewed
Oct 13, 2019
specify that sass styles are compressed
In order to use {% include file_name.ext %} the file_name.ext must be inside the _includes directory
shushugah
requested changes
Oct 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! I left two more comments. I am thankful you picked this issue up! 🎉
front matters are only used by Jekyll
shushugah
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.