Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin page user modal fails to display phone numbers #17

Closed
turbomaze opened this issue Apr 26, 2017 · 2 comments · Fixed by #18
Closed

Admin page user modal fails to display phone numbers #17

turbomaze opened this issue Apr 26, 2017 · 2 comments · Fixed by #18

Comments

@turbomaze
Copy link
Member

  • the admin page allows you to click on users to see their information
  • one of the fields provided by default is a phone number field
  • in the user model this is "confirmation.phoneNumber", but in the admin modal logic it is referred to as "confirmation.phone"

PR incoming

@ehzhang
Copy link
Contributor

ehzhang commented Apr 26, 2017

This is a kind of annoying since the modal and the link to the specific person use copies of the same template basically. Would be nice to consolidate somehow!

@turbomaze
Copy link
Member Author

Yeah, it's challenging though because you may want custom display logic for your modal that you can't guess from just the schema. For instance, if someone "wants hardware", displaying an icon instead of a boolean. My pr #18 just fixes the variable name

Daniel-Ev-Esc pushed a commit to Daniel-Ev-Esc/quill_pruebas that referenced this issue Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants