Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on workshop #349

Merged
merged 16 commits into from
Jul 10, 2022
Merged

Conversation

leoleoasd
Copy link
Collaborator

@leoleoasd leoleoasd commented Jan 22, 2022

Gradually remove dependency on workshop since they are no longer interested in maintaining support for this repo (James-Yu/LaTeX-Workshop#3057).
Tasks:

  • Manager
  • getGraphicsPath
  • completer.command.usedPackages
  • viewer (Won't fix for now)

Support of tikz live preview seems a lot of work, maybe I'll refactor the current implementation.

When selecting format, template with ${wordsBody} will come with a prompt
that tells users that this format only counts words in the body.

closes #134

Signed-off-by: Leo Lu <luyuxuanleo@gmail.com>
Signed-off-by: Leo Lu <luyuxuanleo@gmail.com>
Signed-off-by: Leo Lu <luyuxuanleo@gmail.com>
Signed-off-by: Leo Lu <luyuxuanleo@gmail.com>
Signed-off-by: Leo Lu <luyuxuanleo@gmail.com>
@tecosaur
Copy link
Owner

Feel free to merge this whenever you feel comfortable doing so. Just poke me when you think a release is in order.

@leoleoasd
Copy link
Collaborator Author

Still need couple changes, for example
,Remove dependency on GetGraphicsPath.
I'll find some time to fix it this week

@tecosaur
Copy link
Owner

Cool, no pressure. I just wanted to make sure you weren't waiting for a review from me. I'd love to, but quite I simply don't have the time and so I'm just trusting you 🙂.

old behavior: save image to old directory after switch file

Signed-off-by: Leo Lu <luyuxuanleo@gmail.com>
@leoleoasd
Copy link
Collaborator Author

Finally got some spare time after my crazy junior year. All functions should be working now (except for Tikz preview, I'm considering removing this feature?). I noticed that pasting images from WSL remote isn't working. I tried to fix that but I'm waiting for the reply from PowerShell developers (See PowerShell/PowerShell#17623). After that, I think we can finally release this!

@tecosaur
Copy link
Owner

tecosaur commented Jul 4, 2022

That's great to hear!

@asteppke
Copy link

asteppke commented Jul 4, 2022

@leoleoasd: Thank you, that's great news! The TikZ preview might not be essential but as other previewers (TikZedt ...) are not working well this would be sad to drop. Even the most basic support would be useful.

@leoleoasd
Copy link
Collaborator Author

Things needed from Workshop side are PDF viewers. Using existing code from Workshop requires lots of work (they implemented things like synctex, which we don't require), I'll try to find another way to preview rendered pdf after other functions are merged and released.

@leoleoasd
Copy link
Collaborator Author

I think this is ready for release & publish!
For anyone who wants to try it, here is a built package:
latex-utilities-0.4.0.zip

@leoleoasd
Copy link
Collaborator Author

Sent an email to @tecosaur to discuss the publish process. I'm pinging here since my last email serval month ago goes into the junk box.

@tecosaur
Copy link
Owner

tecosaur commented Jul 7, 2022

Got your email 🙂 and glad for the ping too (I seem to loose the odd email on busy days...). I'll get back to you on publishing in a few hours.

@leoleoasd leoleoasd marked this pull request as ready for review July 9, 2022 03:46
@leoleoasd
Copy link
Collaborator Author

Just to remind @tecosaur, I haven't received the email yet.

@tecosaur
Copy link
Owner

tecosaur commented Jul 9, 2022

Ah yep 😅 I was overly ambitious on Thursday and forgot how busy I was. I should have said, "I'll get back to you on the weekend".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants