-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on workshop #349
Conversation
When selecting format, template with ${wordsBody} will come with a prompt that tells users that this format only counts words in the body. closes #134 Signed-off-by: Leo Lu <luyuxuanleo@gmail.com>
Signed-off-by: Leo Lu <luyuxuanleo@gmail.com>
Signed-off-by: Leo Lu <luyuxuanleo@gmail.com>
Signed-off-by: Leo Lu <luyuxuanleo@gmail.com>
Signed-off-by: Leo Lu <luyuxuanleo@gmail.com>
Signed-off-by: Leo Lu <luyuxuanleo@gmail.com>
Feel free to merge this whenever you feel comfortable doing so. Just poke me when you think a release is in order. |
Still need couple changes, for example |
Cool, no pressure. I just wanted to make sure you weren't waiting for a review from me. I'd love to, but quite I simply don't have the time and so I'm just trusting you 🙂. |
old behavior: save image to old directory after switch file Signed-off-by: Leo Lu <luyuxuanleo@gmail.com>
Finally got some spare time after my crazy junior year. All functions should be working now (except for Tikz preview, I'm considering removing this feature?). I noticed that pasting images from WSL remote isn't working. I tried to fix that but I'm waiting for the reply from PowerShell developers (See PowerShell/PowerShell#17623). After that, I think we can finally release this! |
That's great to hear! |
@leoleoasd: Thank you, that's great news! The TikZ preview might not be essential but as other previewers (TikZedt ...) are not working well this would be sad to drop. Even the most basic support would be useful. |
Things needed from Workshop side are PDF viewers. Using existing code from Workshop requires lots of work (they implemented things like synctex, which we don't require), I'll try to find another way to preview rendered pdf after other functions are merged and released. |
Waiting for PowerShell/PowerShell#17623 to be resolved Signed-off-by: Leo Lu <luyuxuanleo@gmail.com>
I think this is ready for release & publish! |
Sent an email to @tecosaur to discuss the publish process. I'm pinging here since my last email serval month ago goes into the junk box. |
Got your email 🙂 and glad for the ping too (I seem to loose the odd email on busy days...). I'll get back to you on publishing in a few hours. |
Just to remind @tecosaur, I haven't received the email yet. |
Ah yep 😅 I was overly ambitious on Thursday and forgot how busy I was. I should have said, "I'll get back to you on the weekend". |
Gradually remove dependency on workshop since they are no longer interested in maintaining support for this repo (James-Yu/LaTeX-Workshop#3057).
Tasks:
viewer(Won't fix for now)Support of tikz live preview seems a lot of work, maybe I'll refactor the current implementation.