Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate into ember-mocha? #35

Closed
rwjblue opened this issue Feb 11, 2016 · 3 comments
Closed

Migrate into ember-mocha? #35

rwjblue opened this issue Feb 11, 2016 · 3 comments

Comments

@rwjblue
Copy link

rwjblue commented Feb 11, 2016

I'd like to reduce the general number of "moving parts" in ember-mocha as I prepare to start working on implementation for emberjs/rfcs#119.

@teddyzeenny - Would it be OK for me to inline the work you have done here, into ember-mocha (with proper credit of course)?

@teddyzeenny
Copy link
Owner

Sure :) Feel free to do whatever makes things easier for you.
Thanks for working on emberjs/rfcs#119

@Turbo87
Copy link
Contributor

Turbo87 commented Nov 11, 2016

I think we can (and probably should) migrate away from ember-mocha-adapter in ember-mocha and ember-cli-mocha. Reason for this is that overriding it(), beforeEach(), afterEach(), ... has caused several problems in the past and seems largely incompatible with some changes in Mocha 3.x.

from what I understand we have two options to support our special async testing semantics:

  • use something like it('some test', wrapSpecialAsyncFoo(function() { ... }));
  • deprecate it() specs that use async functions but don't return a Promise

@dgeb @rwjblue @teddyzeenny opinions?

@Turbo87
Copy link
Contributor

Turbo87 commented Dec 9, 2016

@teddyzeenny this issue can be closed, now that emberjs/ember-mocha#120 is merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants