Namespace Support #149
Merged
Namespace Support #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constructor is no longer there- instead there is a setDriver and setKey function. The Item class no longer accepts a string for a key, it must be provided with an array. This was done for efficiency (since the Pool class already converts it to an array) and to make namespacing easier. This does break previous API compatibility, however it should have minimal affects as these functions are all used internally (typically by the Pool class when generating the Item).
This also updates the Pool class to use the new API for Items.
This reflect the new API changes that were made.
If a namespace is set flush() will only clear that specific namespace. Otherwise the entire pool gets cleared.
The xcache extension does not run on the command line, making code coverage impossible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces Namespace functionality. It does so via two functions- setNamespace and getNamespace- in the Pool class.