Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table.rows.clear() method for chunking table row updates #1094

Merged
merged 3 commits into from
Nov 22, 2021

Conversation

ttemple06
Copy link
Contributor

#1087

What this does: adds new method table.rows.clear()

@dhensby
Copy link
Collaborator

dhensby commented Sep 18, 2020

Great, this looks nice.

Please can you add a test and address the linting issues? I also think this can go into the v6 branch - please can you retarget the PR and rebase your work?

@dhensby dhensby mentioned this pull request Nov 19, 2020
Copy link
Collaborator

@dhensby dhensby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to add this to the project but there are a few things to sort out, please:

  • Add tests
  • Update docs
  • Rebase against 6 branch
  • Squash / cleanup commit history

@dhensby dhensby changed the title Update table.js Add table.rows.clear() method for chunking table row updates Nov 19, 2020
@dhensby dhensby changed the base branch from master to 6 November 19, 2020 12:16
@dhensby dhensby added this to the v8.0.0 milestone Sep 20, 2021
@dhensby dhensby changed the base branch from 6 to master November 22, 2021 10:09
@dhensby dhensby self-requested a review November 22, 2021 10:19
@dhensby dhensby merged commit 8c85f77 into tediousjs:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants