Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update table.js #1124

Closed
wants to merge 3 commits into from
Closed

Update table.js #1124

wants to merge 3 commits into from

Conversation

ttemple06
Copy link
Contributor

#1087
What this does: adds new method table.rows.clear()

dhensby
dhensby requested changes Nov 19, 2020
View reviewed changes
Copy link
Collaborator

@dhensby dhensby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry with the delay looking into this.

I'm happy to add this to the project but there are a few things to sort out, please:

  • Add tests
  • Update docs
  • Rebase against 6 branch
  • Squash / cleanup commit history

@dhensby
Copy link
Collaborator

dhensby commented Nov 19, 2020

sorry, I'm going to close this as a duplicate of #1094

@dhensby dhensby closed this Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhensby dhensby dhensby requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ttemple06 @dhensby