feat: support text and image data type in bulk loads

tediousjs · Aug 9, 2021 · 573426f · 573426f
1 parent 3ecb650
commit 573426f
Show file tree

Hide file tree

Showing 4 changed files with 129 additions and 2 deletions.
diff --git a/src/bulk-load.ts b/src/bulk-load.ts
@@ -120,6 +120,17 @@ interface ColumnOptions {
 }
 
 const rowTokenBuffer = Buffer.from([ TOKEN_TYPE.ROW ]);
+const textPointerAndTimestampBuffer = Buffer.from([
+  // TextPointer length
+  0x10,
+
+  // TextPointer
+  0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+
+  // Timestamp
+  0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
+]);
+const textPointerNullBuffer = Buffer.from([0x00]);
 
 // A transform that converts rows to packets.
 class RowTransform extends Transform {
@@ -183,6 +194,14 @@ class RowTransform extends Transform {
         value: value
       };
 
+        if (value == null) {
+          this.push(textPointerNullBuffer);
+          continue;
+        }
+
+        this.push(textPointerAndTimestampBuffer);
+      }
+
       this.push(c.type.generateParameterLength(parameter, this.mainOptions));
       for (const chunk of c.type.generateParameterData(parameter, this.mainOptions)) {
         this.push(chunk);
@@ -611,6 +630,11 @@ class BulkLoad extends EventEmitter {
       // TYPE_INFO
       tBuf.writeBuffer(c.type.generateTypeInfo(c, this.options));
 
+      // TableName
+      if (c.type.hasTableName) {
+        tBuf.writeUsVarchar(this.table, 'ucs2');
+      }
+
       // ColName
       tBuf.writeBVarchar(c.name, 'ucs2');
     }

diff --git a/src/data-types/image.ts b/src/data-types/image.ts
@@ -34,7 +34,7 @@ const Image: DataType = {
     }
 
     const buffer = Buffer.alloc(4);
-    buffer.writeInt32LE(parameter.length!, 0);
+    buffer.writeInt32LE(parameter.value.length!, 0);
     return buffer;
   },
 

diff --git a/src/data-types/text.ts b/src/data-types/text.ts
@@ -37,7 +37,7 @@ const Text: DataType = {
     }
 
     const buffer = Buffer.alloc(4);
-    buffer.writeInt32LE(parameter.length!, 0);
+    buffer.writeInt32LE(parameter.value.length!, 0);
     return buffer;
   },
 

diff --git a/test/integration/bulk-load-test.js b/test/integration/bulk-load-test.js
@@ -1536,6 +1536,109 @@ describe('BulkLoad', function() {
       done();
     }
   });
+
+  it('supports bulk loading into a `text` column', function(done) {
+    const expectedRows = [
+      { value: 'some text' },
+      { value: null }
+    ];
+
+    const bulkLoad = connection.newBulkLoad('#tmpTestTable', (err, rowCount) => {
+      if (err) {
+        done(err);
+      }
+
+      assert.strictEqual(rowCount, expectedRows.length);
+
+      /** @type {unknown[]} */
+      const results = [];
+      const request = new Request(`
+        SELECT value FROM #tmpTestTable
+      `, (err) => {
+        if (err) {
+          done(err);
+        }
+
+        assert.deepEqual(results, expectedRows);
+
+        done();
+      });
+
+      request.on('row', (row) => {
+        results.push({ value: row[0].value });
+      });
+
+      connection.execSql(request);
+    });
+
+    bulkLoad.addColumn('value', TYPES.Text, { nullable: true });
+
+    const request = new Request(`
+      CREATE TABLE "#tmpTestTable" (
+        [value] text NULL
+      )
+    `, (err) => {
+      if (err) {
+        return done(err);
+      }
+
+      connection.execBulkLoad(bulkLoad, Readable.from(expectedRows));
+    });
+
+    connection.execSqlBatch(request);
+  });
+
+  it('supports bulk loading into a `image` column', function(done) {
+    const expectedRows = [
+      { value: Buffer.from([0xDE, 0xAD, 0xBE, 0xEF]) },
+      { value: null }
+    ];
+
+    const bulkLoad = connection.newBulkLoad('#tmpTestTable', (err, rowCount) => {
+      if (err) {
+        done(err);
+      }
+
+      assert.strictEqual(rowCount, expectedRows.length);
+
+      /** @type {unknown[]} */
+      const results = [];
+
+      const request = new Request(`
+        SELECT value FROM #tmpTestTable
+      `, (err) => {
+        if (err) {
+          done(err);
+        }
+
+        assert.deepEqual(results, expectedRows);
+
+        done();
+      });
+
+      request.on('row', (row) => {
+        results.push({ value: row[0].value });
+      });
+
+      connection.execSql(request);
+    });
+
+    bulkLoad.addColumn('value', TYPES.Image, { nullable: true });
+
+    const request = new Request(`
+      CREATE TABLE "#tmpTestTable" (
+        [value] image NULL
+      )
+    `, (err) => {
+      if (err) {
+        return done(err);
+      }
+
+      connection.execBulkLoad(bulkLoad, Readable.from(expectedRows));
+    });
+
+    connection.execSqlBatch(request);
+  });
 });
 
 describe('Bulk Loads when `config.options.validateBulkLoadParameters` is `true`', () => {