fix: correct SmallDateTime upper bound range #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockymadden
force-pushed
the
fix-smalldatetime-range
branch
from
5ae126f
to
3a58a61
Compare
MichaelSun90
requested changes
Apr 30, 2024
MichaelSun90
requested changes
May 13, 2024
MichaelSun90
approved these changes
Jun 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1621 +/- ##
==========================================
- Coverage 78.48% 78.46% -0.03%
==========================================
Files 93 93
Lines 4861 4861
Branches 933 933
==========================================
- Hits 3815 3814 -1
Misses 750 750
- Partials 296 297 +1 ☔ View full report in Codecov by Sentry. |
|
@arthurschreiber , can I just go ahead and merge this one? after the branch is up to date? |
Yep! |
|
🎉 This PR is included in version 18.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a PR :
masterbranch of the repository.npm installin the root folder.npm run-script test-all). During development, to run individual test usenode_modules/nodeunit test/<test_file.js> -t <test_name>.npm run build).npm run lint).node_modules/.bin/commitlint --from origin/master --to HEAD). Refer commit conventions and commit rules.Thank you for Contributing!