Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility and Test Fixes from @Takbal #80

Merged
merged 3 commits into from
Jan 1, 2016
Merged

Conversation

tedsteiner
Copy link
Owner

@takbal I really appreciate all the effort you put into #79. I'm using this pull request to track my progress as I work through understanding the changes you made.

@tedsteiner
Copy link
Owner Author

The compatibility changes in this commit from @takbal allowed the tests to pass for me on both OS X El Capitan and Ubuntu 14.04.

Like @takbal mentioned, I also saw that the plots.jl tests took significantly longer with Julia 0.4.2 than they ever did previously, probably because it has over 3.8 GB of memory allocations for some reason. My guess is that this is internal to Winston.jl rather than this package, which is unfortunate but something we'll probably just have to deal with.

I'm pretty sure that the test failures on Travis are due to LibExpat.jl issues rather than related to this package. I still don't know what to do about this, but no machine I've ever tested on has ever reproduced this problem with LibExpat.jl, so I believe it to be Travis-specific.

@tedsteiner tedsteiner self-assigned this Jan 1, 2016
@tedsteiner tedsteiner added the bug label Jan 1, 2016
@tedsteiner tedsteiner changed the title Compatibility and Test Upgrades from Takbal Compatibility and Test Fixes from @Takbal Jan 1, 2016
…3.7 and 0.4.2.

Signed-off-by: Ted Steiner <tsteiner2@gmail.com>
# Conflicts:
#	src/routing.jl
tedsteiner added a commit that referenced this pull request Jan 1, 2016
@tedsteiner tedsteiner merged commit 8af1d67 into master Jan 1, 2016
@tedsteiner tedsteiner deleted the 042-compat-ted branch January 1, 2016 22:08
@tedsteiner tedsteiner mentioned this pull request Jan 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants